Everything on your list involved the sale of a product, by this logic China would be our closest ally (actually I wish our leaders were that sane, but the inconsistency stands...).

I wish people could just state the transparently documented historical truth, Israel is a US ally because Truman and enough other backers wanted to create a state for Holocaust survivors. The leadership and majority of voters in the US have been true believers in Zionism (in one of its many versions) for generations, and supports Israel by essentially the same logic that Israelis support Israel by. This existed as a state of affairs with almost no opposition at any level until a couple years ago when it came into conflict with another basic belief (about being close enough to just in the cause and method of war that most people could somewhat believe it).