Hacker News new | past | comments | ask | show | jobs | submit login

We used to have a "2 approvals" policy on PRs. It wasn't fully enforced, it was a plugin to Gitlab we built that would look for two "+1" comments to unhide the merge button.

I used to create PRs and then review my own code. If I liked it, I'd +1 it. If I saw problems, I'd -1 it. Other engineers would yell at me that I couldn't +1 my own code. When I showed them PRs that had my -1 on it, they just threw their hands up and moved on, exasperated.

I've carried that habit of reviewing my own code forward, even though we now have real checks that enforce a separate reviewer. It's a good habit.




<Author pushing> and <author, the aftermath> are separate states of being. It makes sense to me.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: