I find a good manager treats me like a peer and not some superior. Part of that is being in the trenches and having experience with what I'm working on. Maybe they're not taking on entire features anymore or doing the same level of code review as others but I think for a manager who manages ICs - they should be much closer to the code. Maybe this would be the "team lead" in some companies or a supervisor type role but I think I prefer that kind of person to be my actual manager than some other nebulous person who doesn't even interact with me on a daily basis.

A big problem I had with some managers who didn't code was that they sometimes had wild expectations. They were also not good mentors. They couldn't really teach you much of anything because their job was so distinctly different from what you were doing.