> If someone already consented to using iCloud to store their photos then I would not consider the service mentioned this post to be such a big issue, because Apple would already have the data on their servers with the user's consent.

No, if you enable Advanced Data Protection for iCloud[1], the photos stored in Apple Photos are end to end encrypted.

[1] https://support.apple.com/en-us/108756