Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Then in 3 months someone in between came changing the code slightly that makes comment obsolete but doesn’t update the comment. Making all worse not better.

Issue trackers are much better because then in git you can find tickets attached to the change.

No ticket explaining why - no code change.

Why not in repo? because business people write tickets not devs. Then tickets are passed to QA who also does read the code but also need that information.



Why did the reviewer approve the change if the developer didn’t update the comment?

It sounds like people are failing at their jobs.


Oh that is one of my pet peeves.

"If only people would do their jobs properly".

So we just fire all the employees and hire better ones only because someone did not pay attention to the comment.

Of course it is an exaggeration - but also in the same line people who think "others are failing at their jobs" - should pick up and do all the work there is to be done and see how long they go until they miss something or make a mistake.

Solution should be systematic to prevent people from failing and not expecting "someone doing their job properly".

Not having comments as something that needs a review reduces workload on everyone involved.

Besides, interfaces for PRs they clearly mark what changed - they don't point what hasn't been changed. So naturally people review what has changed. You still get the context of course and can see couple lines above and below... But still I blame the tool not people.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: