Hacker News new | past | comments | ask | show | jobs | submit login

>proprietary shitware

Is this shitware? It seems to be very high quality code




I think the anger comes from the fact that we expect Github repositories to host the actual source code and not be a dead-end with a single README.md file.


How can you tell?


I mean, based on the claims and the benchmarks, it seems to provide massive speedups to a very popular tool.

How would you define "quality" in this context?


High quality code isn't just code that performs well when executed, but also is readable, understandable and maintainable. You can't judge code quality by looking at the compiled result, just because it works well.


That's certainly one opinion about it.

One could also say that quality is related to the functional output.


> One could also say that quality is related to the functional output.

Right, I said nothing that contradicts that ("High quality code isn't just code that performs well when executed, but also ..."). High quality functional output is a necessary requirement, but it isn't sufficient to determine if code is high quality.


Sure, I guess it depends on what matters to you or to your evaluation criteria.

My point was that it's all subjective in the end.


It's not really subjective if you're at all reasonable about it.

Imagine writing a very good program, running it through an obfuscator, and throwing away the original code. Is the obfuscated code "high quality code" now, because the output of the compilation still works as before?


Again it depends what you mean by "high quality code".

Do you mean how well it was written, or do you mean how well it performs? Or do both matter? Equally, or one more/less than the other?

It probably depends on whether you're the developer taking over the codebase, or the customer running the code in production..

Take video games.. A lot of it is messy spaghetti C++ code, not modular or well structured, full of hacks and manual optimizations, to give the best possible performance on available hardware.

It might be impossible to parse or maintain, but it does the job about as well as possible, which is really all that matters to the end user. I would call that high quality code.

So again, subjective...


Written so that it's easy to maintain, well tested, correct in its handling of edge cases, easy to debug, and easy to iterate on.




Consider applying for YC's Spring batch! Applications are open till Feb 11.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: