Never said it wasn’t legal for states to adopt it—said it’s not real democracy and disenfranchises votes.

Whose votes get disenfranchised?

If your state participates in the compact, but votes for the loser of the overall popular vote, all of those votes are disenfranchised.

No, they are not. Not anymore than anyone else's vote who voted for a candidate who didn't win.

You are only disenfranchised if your votes can't affect the outcome in practice or in principle. Like, say, the votes for president of Republicans in California or those of Democrats in Texas in practice. Or the votes of those in Puerto Rico even in principle.