In every war, someone gains something, but War on Terror was detrimental to the US as a whole, and the American population understands that - which is why the hawks are really unpopular right now. The defeat of H.C. in 2016 can at least partly be explained by the fact that she was considered a foreign policy hawk.

Compare this to wars of Ancient Rome which were actually popular, because they brought home visible wealth.