While foreign allies showed a lot of interest in his revelations. Notwithstanding his morally high intentions, it's debatable whether the USA as a whole got a positive outcome from his actions.
What do you mean it's debatable? The govt was literally spying on the whole country without any disclosure. The actual people who live and were being spied on have at least an idea of their true circumstances now.
"it's debatable whether the USA as a whole got a positive outcome from his actions."
I could make the case that while what Snowden did was heroic, and praiseworthy in a just and educated nation, the US is ultimately neither a just nor educated nation, and too little changed as a result of his whistleblowing. Go ask 100 truly random people what they think of Snowden's revelations and you may find yourself quite disappointed. John Oliver did an episode on this and it was more than a little depressing: https://www.youtube.com/watch?v=XEVlyP4_11M
