> repeatedly annoying non-user visitors doesn't make them want to sign up?

It absolutely does, and that is precisely why they keep doing it. It doesn't work for the kinds of people that browse hackernews, but that's not their core audience anyway.

It's like saying ads don't work because you and me never click them because we use an adblock. Clearly they do work, and quite well...