That's a very interesting move. The patch seems fairly small, but now it's a patch that Brave needs to maintain and update every time they merge a new upstream version.
That's what makes me wary of the whole Chromium fork concept. Every time Brave/Vivaldi/Edge/etc decide to take a different path from Google's they effectively add to their maintenance burden forever, even if like in this case they actually disable an unwanted feature.
How long until the list of patches to backport for every new version of Chromium becomes so large that they have to pick and choose which one to keep maintaining and which one to give up on? If tomorrow Google decides to push a very deep change to the way, say, extensions are handled that makes them less effective at ad blocking, will Brave accept the burden to suddenly have to maintain a very deep fork of the browser in order to maintain old functionality?
I'm effectively FUDing right now, but my concern is genuine. I'm very perplex that you can make an effectively anti-ad, pro-privacy browser based on the source code of one of the biggest ad companies in the world.
From what I'm remembering, Eich said that once they got big enough, they'd be willing to fork a browser if necessary. I wouldn't put that past Brave considering how many changes it's had (used to be on a different browser engine, also used to use Electron). They'll probably have to grow a bit before this happens though.
I maintained a fork of webkit ~12 years ago and it was a nightmare to maintain because every couple months they would massively reengineer systems and result in hundreds of non-trivial file changes. And because webkit had a brain-dead way of implementing multi-platform support it meant you spent days or weeks re-integrating these changes.
There is a small team of folks here constantly working on rebasing the next Chromium version on Brave. They fight these deviations and try to minimize the patching as much as possible- so future versions are easier and easier. We even have some clever UI patching for the Polymer pages
There definitely have been challenges - for example, with Chromium 69, the network delegates were moved over to NetworkService which broke our shields code. But I'm really proud of the work done to minimize things. For a long time, the team rebasing Chromium was just one person... and we've always delivered Chromium upgrades and updates to Brave users within 24-48 hours of Google's stable channel
The idea of a fork is that it is independent from what it was forked from, you pull what you like and leave aside negative changes, if the license allows this. At least that's the idea. Of course companies with huge manpower such as google can evolve "standards" in a pace that a small independent fork can't keep pace, but we shouldn't just give up.
I think the type of fork that OC was referring to would be a project that forks to provide a change in feature set, yet still tries to remain up to date with upstream. So, not a hard fork.
My guess is they run the cost benefit analysis with every Chrome release. Then just give up and accept the change unless it's obviously low cost or in an area they've already forked.
That's what makes me wary of the whole Chromium fork concept. Every time Brave/Vivaldi/Edge/etc decide to take a different path from Google's they effectively add to their maintenance burden forever, even if like in this case they actually disable an unwanted feature.
How long until the list of patches to backport for every new version of Chromium becomes so large that they have to pick and choose which one to keep maintaining and which one to give up on? If tomorrow Google decides to push a very deep change to the way, say, extensions are handled that makes them less effective at ad blocking, will Brave accept the burden to suddenly have to maintain a very deep fork of the browser in order to maintain old functionality?
I'm effectively FUDing right now, but my concern is genuine. I'm very perplex that you can make an effectively anti-ad, pro-privacy browser based on the source code of one of the biggest ad companies in the world.