I've used fish in the past but went back to zsh. IIRC fish broke a bunch of times between versions and the maintainer feedback wasn't great. The maintainers of course don't owe me any of their time, so I'm not mad about it, I just don't use it anymore because I need my shell to work reliably every time I open a terminal. (I don't remember the precise problem but I'm sure I could go find it.)

I now use zsh with zgen and a smattering of modules. It works fine, doesn't have the issue that you have to first translate every snippet you find to your new shell, and it's still easy for the newer shell users in your life to use.