Hacker News new | past | comments | ask | show | jobs | submit login

    function hidestory (ev, el, id) {
      for (var i=0; i < 3; i++) {
That 3 there is the problem with “simple” JS. It’s tightly coupled to the HTML but they live in completely different places.

On a side note this 3 should be at least assigned to a variable with a meaningful name.




Except there isn't any problem here whatsoever. Yes, it's coupled, but it doesn't matter. No, this kind of code doesn't scale. It doesn't have to.

The time you spent writing this comment was longer than what it took writing this code. Considering what kind of site this is, that code may work indefinitely. Or, if necessary, someone from the future will need to change that 3 to a 4 at some point. In terms of total cost, it's almost certainly the cheapest solution.


And how will that someone know what that 3 stands for ? At the minimum a comment above that line would have been nice.


They'll figure it out. They're a programmer, figuring things out is their job.


hidestory() is not even used anywhere ; why is it here for? Debugging?


It's called by the "hide" link under each story on the top page.


It is probably called in an onclick=“” in the HTML somewhere


Like JS is never attached to a HTML template ?


Is this sarcasm? I hope it is.




Consider applying for YC's Spring batch! Applications are open till Feb 11.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: