Hacker News new | past | comments | ask | show | jobs | submit login

> You just sound lazy and apathetic.

And it sounds like you are quick to rush to judgment.

You're essentially accusing me of doing exactly what you are doing. You could have instead asked more about the context within which this all happened (which was a pretty bad situation to begin with) and if I tried to work with the person submitting the pull request.

Instead, you make me out for lazy (which is something that I don't think anybody that knows even a little bit about me) and apathetic (which also doesn't fit the bill, rather the contrary).

You can take as much time as you need to do a review if you have that time. The middle of a house fire is not the right moment to push through your pet project, and it also doesn't mean that if I point blank refuse a pull like that that I had not thought it through.




I said you _sound_ lazy and apathetic... if there was more context then maybe you should include it in your argument in the first place (which is all I'm responding to, it's not personal). All I have to go off of is a post where you describe a coworker submitting his "masterpiece", you admitting it was clear a lot of hard work went into it, and you rejecting it because it's too big. That, alone, is rather annoying IMO. As someone who will both review and submit bigger PRs that try to move the needle in ways that aren't possible with a 200 line diff, I would be extremely frustrated with your stance of "too big can't merge" with no other context. We've all been there under pressure faced with the decision of whether we can responsibly merge something or not. I'm sure you made the right call for your situation. But you suggested _categorically_ rejecting large PRs. I'm not the only one that took issue with that and it's much different than the scenario you've now described (lots of problematic, hard to parse, code with a tight deadline).




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: