Interesting, I've never even heard of a brown onion. I thought the cheap standard onions were white, and I always buy yellow.

I'm even a gardener! (But I just buy whatever sets they have locally)

Brown onions are also known as yellow onions; depends on your locale. I guess the locale of the recipe's author matters as well (although it usually doesn't matter too much if you use a white or brown onion).