Would a cylinder be strong enough? The Germans are talking about operating at a depth of 700m, which is more than twice the maximum depth (300m) of the example analyzed in the paper you cited.
These pipelines have some inner pressure. The idea is here however that a pressure differential is used to drive a turbine. The greater the differential the more energy. The engineering challenges are not really comparable.
The US Navy's DSRV's you referenced do not have cylindrical pressure vessels. The cylindrical external hull encloses 3 linked spheres that are the actual pressure vessel. BTW, the DSRV's were retired several years ago.
Seems to me that if you use compressed air to displace water within the sphere, you could actually store more energy this way... That would require the air to drive electric generators when the sphere is being filled with water though.
Once you start compressing and decompressing air you get a lot of heat loss though, that I would imagine isn't as much of an issue when you're just pumping plain water back and forth